Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete uncleaned_roots in accounts index. #4092

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Obsolete uncleaned_roots in accounts index. #4092

merged 8 commits into from
Dec 31, 2024

Conversation

HaoranYi
Copy link

@HaoranYi HaoranYi commented Dec 12, 2024 •
edited
Loading

Problem

In PR#4044, we no longer filter clean by uncleaned_roots. All slots that are older than the max_root_to_clean are considered in clean.

The concept of uncleaned_roots is now obsolete. And we should remove it.

Summary of Changes

Remove uncleaned_roots from account index.

Fixes #

@HaoranYi HaoranYi changed the title remove uncleaned_slots Obsolete uncleaned_roots in accounts index. Dec 12, 2024
@HaoranYi HaoranYi marked this pull request as draft December 12, 2024 22:55
@HaoranYi HaoranYi mentioned this pull request Dec 13, 2024
Merged
@HaoranYi HaoranYi marked this pull request as ready for review December 13, 2024 15:25
@HaoranYi HaoranYi force-pushed the remove_uncleaned_root branch from daa833f to 3133d8e Compare December 13, 2024 21:25
brooksprumo
brooksprumo reviewed Dec 13, 2024
View reviewed changes
accounts-db/src/accounts_db.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db.rs Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
@HaoranYi HaoranYi requested a review from brooksprumo December 13, 2024 23:09
brooksprumo
brooksprumo reviewed Dec 16, 2024
View reviewed changes
accounts-db/src/accounts_db.rs Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
@HaoranYi HaoranYi force-pushed the remove_uncleaned_root branch from 6ba07a4 to 0eb57e4 Compare December 16, 2024 20:32
@HaoranYi
Copy link
Author

Rebase to pick up #4147.

brooksprumo
brooksprumo reviewed Dec 16, 2024
View reviewed changes
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now! Two tiny nits:

accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db/tests.rs Outdated Show resolved Hide resolved
brooksprumo
brooksprumo approved these changes Dec 16, 2024
View reviewed changes
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I think it'd be good to get @jeffwashington to double check as well

@HaoranYi
Copy link
Author

HaoranYi commented Dec 19, 2024 •
edited
Loading

The following graph shows the number of open append_vec from dev2, which are running with this PR for two days on mainnet. These numbers look normal.

image

jeffwashington
jeffwashington approved these changes Dec 31, 2024
View reviewed changes
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HaoranYi HaoranYi merged commit d64e0a1 into anza-xyz:master Dec 31, 2024
40 checks passed
@HaoranYi HaoranYi deleted the remove_uncleaned_root branch December 31, 2024 18:21
@HaoranYi HaoranYi mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwashington jeffwashington jeffwashington approved these changes

@brooksprumo brooksprumo brooksprumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoranYi @brooksprumo @jeffwashington